i18n: use user's local for date inputs #6412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
Light2Dark
reviewed
Sep 18, 2025
Contributor
Light2Dark
left a comment
Light2Dark
left a comment
There was a problem hiding this comment.
should this provider wrap islands too?
in web-components.tsx
Contributor
Author
yep, it is there, right? |
Light2Dark
approved these changes
Sep 18, 2025
Contributor
Light2Dark
left a comment
Light2Dark
left a comment
There was a problem hiding this comment.
oops, looks good then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the react-aria i18n provider to set the locale for date inputs.
In a follow-up, I plan to make this configurable in user config (in case a user works for a US company, but based in another country, or vice-versa) and needs it set for reports